Weird - I don't see a "draft" option for this PR, maybe because pharmaverse is a free-tier GitHub org.

Thanks @cicdguy!! Shall I merge this in now?

We have a new CRAN release on Jan 15 be great to work out any kinks before that

Not yet - I'll need to push the past versions into the gh-pages branch. Also I'll do a full check regarding link updates across other repos as they may be referring to admiral articles whose URLs will change as a result of this.

Thanks @cicdguy!! Shall I merge this in now?
We have a new CRAN release on Jan 15 be great to work out any kinks before that

Not yet - I'll need to push the past versions into the gh-pages branch. Also I'll do a full check regarding link updates across other repos as they may be referring to admiral articles whose URLs will change as a result of this.

Roger! I guess that is why you wanted to set it to DRAFT! Just ping me if you want a second set of eyes or to merge in. Thanks again for making this update - I know you are in high demand!

I'll revisit this after the upcoming release. Do not want to disrupt anything that way.

This Pull Request is stale because it has not been worked on in 15 days.

@cicdguy think we can proceed with this PR now. admiral was released on January 15th with no issues identified...so far.

Will the links not be an issue once this is merged into main - the ones with cran-release are all failing.

@bms63 - yes those links will all be updated. There's some other background work required to finish this end-to-end (re-provisioning older version on gh-pages etc), so I'll keep this open until that other work has also been completed.

Update from @cicdguy: progress on this expected by end of month

This Pull Request is stale because it has not been worked on in 15 days.

This Pull Request is stale because it has not been worked on in 15 days.

@cicdguy now that docs are built successfully, i guess this is almost done? 🙏

Almost ready to go. Just need to resolve an issue with Staged Dependencies for tag-based events.

@cicdguy how is this going?

Going good. Tests are running fine. We should be good to merge.

Ok I'll resolve the conflicts and merge tomorrow if no other comments!

Edit: conflicts already resolved

Thanks @cicdguy 😄

Ok I'll resolve the conflicts and merge tomorrow if no other comments!

Oh snap. I resolved it (I think).

Hmm coverage still unhappy :(

Darn, let me fix that.

not sure if it's you, seeing it on other PRs

Yeah it's my bad. Need to fix

Ok should be fixed now.

Ok should be fixed now.

okay to merge this in? we still will have dev version of site?

Yes. Exactly

@cicdguy thanks again!!!

@cicdguy any chance we can not have .9000 appear as version?

Yes, change your tag/DESCRIPTION to the correct version: https://github.com/pharmaverse/admiral/blob/v1.2.0/DESCRIPTION#L4

v1.2.0 has 1.2.0.9000 in the DESCRIPTION file :)

ah darn that is on me then. ummm..

alright fixed up

alright fixed up

@bms63 , I think there went something wrong. The older versions were removed and the cran-release folder was removed from the gh-pages branch. This causes the link checker to fail (see https://github.com/pharmaverse/admiral/actions/runs/15443291847/job/43466150660?pr=2754).

@cicdguy could we get some pointers? I just modified the tag-v1.2.0 and then did a re-release on the updated tag.

Ouch. Yeah that's bad. I'll look into it next week or so.